Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-139: add uuid for guest users #166

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

Add uuid for guest users:

  • create uuid for guest user in local storage
  • add that uuid to header of requests to geoapi

Related Jira tickets:

Testing Steps:

See TACC-Cloud/geoapi#155 for testing steps.

Store in local storage and add to requests headers
@nathanfranklin nathanfranklin changed the title Create a unique id for guest users task/WG-139: add uuid for guest users Oct 30, 2023
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There are several check annotation complaints for some unchanged files, dunno if we need to address these or not:

react/src/components/MapProject/MapProject.tsx
react/src/types/feature.ts
react/src/utils/authUtils.ts
react/vite.config.ts

(This is the same list of issues as #165 )

@nathanfranklin
Copy link
Collaborator Author

@taoteg, i'll take a look at cleaning the react-sid of things as its confusing. will addres in a separate PR. 🎗️

There are several check annotation complaints for some unchanged files, dunno if we need to address these or not:

react/src/components/MapProject/MapProject.tsx
react/src/types/feature.ts
react/src/utils/authUtils.ts
react/vite.config.ts

(This is the same list of issues as #165 )

@nathanfranklin nathanfranklin merged commit e9dd0be into master Nov 3, 2023
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-139-add-uuid-for-guest-users branch November 3, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants